browser_test.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488
  1. package cfbrowser
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "image"
  8. "image/png"
  9. "io"
  10. "os"
  11. "path/filepath"
  12. "strings"
  13. "sync"
  14. "sync/atomic"
  15. "testing"
  16. "time"
  17. "unicode/utf8"
  18. "clusterflow.dev/cfbrowser/api"
  19. "clusterflow.dev/cfbrowser/policy"
  20. )
  21. var testOwner = api.Owner{EnvironmentID: "e", ThreadID: "t", RunID: "r", SSHSessionID: "ssh1"}
  22. type fakeDriver struct {
  23. open func(context.Context, api.EngineOptions) (api.EngineSession, error)
  24. trusted bool
  25. }
  26. func (d *fakeDriver) Probe(ctx context.Context) (api.Capabilities, error) {
  27. if e := ctx.Err(); e != nil {
  28. return api.Capabilities{}, e
  29. }
  30. s := "unsupported"
  31. if d.trusted {
  32. s = "supported"
  33. }
  34. return api.Capabilities{Engine: "fake", Features: map[string]api.Capability{"trustedInput": {Status: s}}}, nil
  35. }
  36. func (d *fakeDriver) Open(ctx context.Context, o api.EngineOptions) (api.EngineSession, error) {
  37. if d.open != nil {
  38. return d.open(ctx, o)
  39. }
  40. return &fakeSession{page: &fakePage{}}, nil
  41. }
  42. type fakeSession struct {
  43. page *fakePage
  44. downloads []api.Download
  45. closed atomic.Bool
  46. failNew bool
  47. }
  48. func (s *fakeSession) NewPage(context.Context) (api.EnginePage, error) {
  49. if s.failNew {
  50. return nil, errors.New("new page failed")
  51. }
  52. return s.page, nil
  53. }
  54. func (s *fakeSession) Downloads() []api.Download { return s.downloads }
  55. func (s *fakeSession) Close() error { s.closed.Store(true); return nil }
  56. type fakePage struct {
  57. eval func(context.Context, string) (json.RawMessage, error)
  58. inputErr error
  59. png []byte
  60. inputCount atomic.Int32
  61. }
  62. func (p *fakePage) Navigate(context.Context, string, string) (string, error) {
  63. return "https://example.org", nil
  64. }
  65. func (p *fakePage) Evaluate(ctx context.Context, script string) (json.RawMessage, error) {
  66. if p.eval != nil {
  67. return p.eval(ctx, script)
  68. }
  69. op, a := scriptArgs(script)
  70. var out any
  71. switch op {
  72. case "snapshot":
  73. out = api.Snapshot{SnapshotID: a["id"].(string), DocumentID: "doc", URL: "https://example.org", Kind: "dom-semantic", Elements: []api.Element{{Ref: "e1", Role: "textbox", Name: "Query"}}}
  74. case "prepare":
  75. out = map[string]any{"x": 1, "y": 2, "tag": "INPUT"}
  76. case "wait":
  77. out = true
  78. case "read":
  79. out = api.ReadResult{Text: "example"}
  80. default:
  81. out = map[string]any{}
  82. }
  83. b, e := json.Marshal(out)
  84. return b, e
  85. }
  86. func (p *fakePage) Input(context.Context, string, string, float64, float64) error {
  87. p.inputCount.Add(1)
  88. return p.inputErr
  89. }
  90. func (p *fakePage) Capture(context.Context) ([]byte, error) {
  91. if p.png != nil {
  92. return p.png, nil
  93. }
  94. var b bytes.Buffer
  95. _ = png.Encode(&b, image.NewRGBA(image.Rect(0, 0, 8, 8)))
  96. return b.Bytes(), nil
  97. }
  98. func (p *fakePage) Close() error { return nil }
  99. func scriptArgs(s string) (string, map[string]any) {
  100. s = s[strings.LastIndex(s, ";return run(")+12:]
  101. s = strings.TrimSuffix(s, ");})()")
  102. var args []json.RawMessage
  103. _ = json.Unmarshal([]byte("["+s+"]"), &args)
  104. var op string
  105. var a map[string]any
  106. if len(args) == 2 {
  107. _ = json.Unmarshal(args[0], &op)
  108. _ = json.Unmarshal(args[1], &a)
  109. }
  110. return op, a
  111. }
  112. func fixture(t *testing.T, trusted bool) (*Manager, *fakeSession, api.SessionInfo, api.PageInfo) {
  113. t.Helper()
  114. s := &fakeSession{page: &fakePage{}}
  115. d := &fakeDriver{trusted: trusted, open: func(context.Context, api.EngineOptions) (api.EngineSession, error) { return s, nil }}
  116. m, e := New(Config{Policy: policy.URLPolicy{AllowOrigins: []string{"https://example.org"}}}, d)
  117. if e != nil {
  118. t.Fatal(e)
  119. }
  120. t.Cleanup(func() { _ = m.Close() })
  121. info, e := m.CreateSession(context.Background(), testOwner)
  122. if e != nil {
  123. t.Fatal(e)
  124. }
  125. p, e := m.NewPage(context.Background(), testOwner, info.ID)
  126. if e != nil {
  127. t.Fatal(e)
  128. }
  129. return m, s, info, p
  130. }
  131. func requireCode(t *testing.T, err error, code string) {
  132. t.Helper()
  133. var e *api.Error
  134. if !errors.As(err, &e) || e.Code != code {
  135. t.Fatalf("expected %s, got %v", code, err)
  136. }
  137. }
  138. func TestOwnershipAndQuotas(t *testing.T) {
  139. m, _, s, p := fixture(t, false)
  140. ctx := context.Background()
  141. other := testOwner
  142. other.RunID = "child"
  143. _, e := m.Snapshot(ctx, other, s.ID, p.PageID, api.SnapshotRequest{})
  144. requireCode(t, e, "BROWSER_SCOPE_MISMATCH")
  145. if len(m.Sessions(other)) != 0 || len(m.Sessions(testOwner)) != 1 {
  146. t.Fatal("session ownership leak")
  147. }
  148. if _, e = m.CreateSession(ctx, api.Owner{}); e == nil {
  149. t.Fatal("invalid owner accepted")
  150. }
  151. if _, e = m.CreateSession(ctx, other); e != nil {
  152. t.Fatal(e)
  153. }
  154. if _, e = m.CreateSession(ctx, other); e == nil {
  155. t.Fatal("session quota ignored")
  156. }
  157. if _, e = m.NewPage(ctx, testOwner, s.ID); e != nil {
  158. t.Fatal(e)
  159. }
  160. if _, e = m.NewPage(ctx, testOwner, s.ID); e != nil {
  161. t.Fatal(e)
  162. }
  163. if _, e = m.NewPage(ctx, testOwner, s.ID); e == nil {
  164. t.Fatal("page quota ignored")
  165. }
  166. if e = m.CloseSession(other, s.ID); e == nil {
  167. t.Fatal("cross-owner close accepted")
  168. }
  169. if e = m.CloseSession(testOwner, s.ID); e != nil {
  170. t.Fatal(e)
  171. }
  172. _, e = m.Read(ctx, testOwner, s.ID, p.PageID, api.ReadRequest{})
  173. requireCode(t, e, "BROWSER_SCOPE_MISMATCH")
  174. }
  175. func TestReferencesAndActions(t *testing.T) {
  176. for _, trusted := range []bool{false, true} {
  177. t.Run(map[bool]string{false: "synthetic", true: "browser"}[trusted], func(t *testing.T) {
  178. m, s, info, p := fixture(t, trusted)
  179. ctx := context.Background()
  180. snap, e := m.Snapshot(ctx, testOwner, info.ID, p.PageID, api.SnapshotRequest{})
  181. if e != nil {
  182. t.Fatal(e)
  183. }
  184. r := api.ActionRequest{SnapshotID: snap.SnapshotID, Ref: "e1", Action: "fill", Value: "test"}
  185. result, e := m.Act(ctx, testOwner, info.ID, p.PageID, r)
  186. if e != nil || result.Effect != "dispatched" {
  187. t.Fatalf("action: %+v %v", result, e)
  188. }
  189. if trusted && s.page.inputCount.Load() != 1 {
  190. t.Fatal("browser input was not used")
  191. }
  192. r.Ref = "guessed"
  193. _, e = m.Act(ctx, testOwner, info.ID, p.PageID, r)
  194. requireCode(t, e, "BROWSER_STALE_REF")
  195. r.Ref = "e1"
  196. _, e = m.Snapshot(ctx, testOwner, info.ID, p.PageID, api.SnapshotRequest{})
  197. if e != nil {
  198. t.Fatal(e)
  199. }
  200. _, e = m.Act(ctx, testOwner, info.ID, p.PageID, r)
  201. requireCode(t, e, "BROWSER_STALE_REF")
  202. if _, e = m.Navigate(ctx, testOwner, info.ID, p.PageID, "https://example.org", "goto"); e != nil {
  203. t.Fatal(e)
  204. }
  205. _, e = m.Act(ctx, testOwner, info.ID, p.PageID, r)
  206. requireCode(t, e, "BROWSER_STALE_REF")
  207. })
  208. }
  209. }
  210. func TestUnknownActionOutcomeIsNotRetried(t *testing.T) {
  211. m, s, info, p := fixture(t, true)
  212. ctx := context.Background()
  213. snap, e := m.Snapshot(ctx, testOwner, info.ID, p.PageID, api.SnapshotRequest{})
  214. if e != nil {
  215. t.Fatal(e)
  216. }
  217. s.page.inputErr = context.DeadlineExceeded
  218. r, e := m.Act(ctx, testOwner, info.ID, p.PageID, api.ActionRequest{SnapshotID: snap.SnapshotID, Ref: "e1", Action: "click"})
  219. requireCode(t, e, "BROWSER_ACTION_OUTCOME_UNKNOWN")
  220. if r.Effect != "unknown" || s.page.inputCount.Load() != 1 {
  221. t.Fatal("unsafe replay or false success")
  222. }
  223. s.page.inputErr = api.Err("BROWSER_WORKER_EXITED", "worker disconnected")
  224. r, e = m.Act(ctx, testOwner, info.ID, p.PageID, api.ActionRequest{SnapshotID: snap.SnapshotID, Ref: "e1", Action: "click"})
  225. requireCode(t, e, "BROWSER_ACTION_OUTCOME_UNKNOWN")
  226. if r.Effect != "unknown" || s.page.inputCount.Load() != 2 {
  227. t.Fatal("worker loss was reported as not dispatched")
  228. }
  229. }
  230. func TestClosePageReclaimsQuotaAndInvalidatesHandles(t *testing.T) {
  231. m, _, info, p := fixture(t, false)
  232. ctx := context.Background()
  233. if e := m.ClosePage(ctx, testOwner, info.ID, p.PageID); e != nil {
  234. t.Fatal(e)
  235. }
  236. if _, e := m.Snapshot(ctx, testOwner, info.ID, p.PageID, api.SnapshotRequest{}); e == nil {
  237. t.Fatal("closed page remained callable")
  238. }
  239. if len(m.Sessions(testOwner)[0].Pages) != 0 {
  240. t.Fatal("closed page retained quota")
  241. }
  242. if _, e := m.NewPage(ctx, testOwner, info.ID); e != nil {
  243. t.Fatal(e)
  244. }
  245. }
  246. func TestReadWaitAndInvalidRequests(t *testing.T) {
  247. m, _, s, p := fixture(t, false)
  248. ctx := context.Background()
  249. if v, e := m.Read(ctx, testOwner, s.ID, p.PageID, api.ReadRequest{}); e != nil || v.Text != "example" {
  250. t.Fatalf("read: %+v %v", v, e)
  251. }
  252. if e := m.Wait(ctx, testOwner, s.ID, p.PageID, api.WaitRequest{Kind: "ready"}); e != nil {
  253. t.Fatal(e)
  254. }
  255. for _, r := range []api.WaitRequest{{Kind: "bad"}, {Kind: "text", TimeoutMS: -1}} {
  256. if m.Wait(ctx, testOwner, s.ID, p.PageID, r) == nil {
  257. t.Fatal("invalid wait accepted")
  258. }
  259. }
  260. for _, r := range []api.SnapshotRequest{{Mode: "html"}, {MaxBytes: 12}, {MaxElements: 151}} {
  261. if _, e := m.Snapshot(ctx, testOwner, s.ID, p.PageID, r); e == nil {
  262. t.Fatal("invalid snapshot accepted")
  263. }
  264. }
  265. for _, r := range []api.ReadRequest{{Mode: "html"}, {MaxBytes: 1}, {Ref: "e1", SnapshotID: "bad"}} {
  266. if _, e := m.Read(ctx, testOwner, s.ID, p.PageID, r); e == nil {
  267. t.Fatal("invalid read accepted")
  268. }
  269. }
  270. if _, e := m.Navigate(ctx, testOwner, s.ID, p.PageID, "file:///etc/passwd", "goto"); e == nil {
  271. t.Fatal("unsafe navigation accepted")
  272. }
  273. if _, e := m.Navigate(ctx, testOwner, s.ID, p.PageID, "", "unknown"); e == nil {
  274. t.Fatal("invalid navigation accepted")
  275. }
  276. if _, e := m.Read(ctx, testOwner, s.ID, "missing", api.ReadRequest{}); e == nil {
  277. t.Fatal("unknown page accepted")
  278. }
  279. }
  280. func TestCancellationOfWaitAndPageQueue(t *testing.T) {
  281. m, s, info, p := fixture(t, false)
  282. started := make(chan struct{})
  283. var once sync.Once
  284. s.page.eval = func(ctx context.Context, _ string) (json.RawMessage, error) {
  285. once.Do(func() { close(started) })
  286. <-ctx.Done()
  287. return nil, ctx.Err()
  288. }
  289. ctx, cancel := context.WithCancel(context.Background())
  290. done := make(chan error, 1)
  291. go func() {
  292. done <- m.Wait(ctx, testOwner, info.ID, p.PageID, api.WaitRequest{Kind: "text", Value: "never"})
  293. }()
  294. <-started
  295. queued, stop := context.WithTimeout(context.Background(), 20*time.Millisecond)
  296. defer stop()
  297. _, e := m.Snapshot(queued, testOwner, info.ID, p.PageID, api.SnapshotRequest{})
  298. if !errors.Is(e, context.DeadlineExceeded) {
  299. t.Fatal(e)
  300. }
  301. cancel()
  302. select {
  303. case e := <-done:
  304. if !errors.Is(e, context.Canceled) {
  305. t.Fatal(e)
  306. }
  307. case <-time.After(time.Second):
  308. t.Fatal("wait did not cancel")
  309. }
  310. }
  311. func TestConcurrentQuotaReservationAndShutdown(t *testing.T) {
  312. started := make(chan struct{})
  313. d := &fakeDriver{open: func(ctx context.Context, _ api.EngineOptions) (api.EngineSession, error) {
  314. close(started)
  315. <-ctx.Done()
  316. return nil, ctx.Err()
  317. }}
  318. m, e := New(Config{MaxSessions: 1}, d)
  319. if e != nil {
  320. t.Fatal(e)
  321. }
  322. defer m.Close()
  323. done := make(chan error, 1)
  324. go func() { _, e := m.CreateSession(context.Background(), testOwner); done <- e }()
  325. <-started
  326. _, e = m.CreateSession(context.Background(), testOwner)
  327. requireCode(t, e, "BROWSER_LIMIT")
  328. if e = m.Close(); e != nil {
  329. t.Fatal(e)
  330. }
  331. if e = m.Close(); e != nil {
  332. t.Fatal(e)
  333. }
  334. select {
  335. case e := <-done:
  336. if e == nil {
  337. t.Fatal("canceled open succeeded")
  338. }
  339. case <-time.After(time.Second):
  340. t.Fatal("shutdown blocked")
  341. }
  342. _, e = m.CreateSession(context.Background(), testOwner)
  343. requireCode(t, e, "BROWSER_CLOSED")
  344. }
  345. func TestBudgetsAndUTF8(t *testing.T) {
  346. s := api.Snapshot{SnapshotID: "id", URL: strings.Repeat("u", 8000), Title: strings.Repeat("题", 200), Text: strings.Repeat("科学\"\n", 2000), Elements: []api.Element{}}
  347. for i := 0; i < 150; i++ {
  348. s.Elements = append(s.Elements, api.Element{Ref: "e", Name: strings.Repeat("名", 256)})
  349. }
  350. if e := fitSnapshot(&s, 1024); e != nil {
  351. t.Fatal(e)
  352. }
  353. b, _ := json.Marshal(s)
  354. if len(b) > 1024 || !s.Truncated || !utf8.ValidString(s.Text) {
  355. t.Fatal("invalid snapshot budget")
  356. }
  357. for i := 0; i < 10; i++ {
  358. if !utf8.ValidString(truncate("科学test", i)) {
  359. t.Fatal("UTF-8 split")
  360. }
  361. }
  362. if fitSnapshot(&api.Snapshot{}, 1) == nil {
  363. t.Fatal("impossible budget accepted")
  364. }
  365. if decode(json.RawMessage(`{"error":"BROWSER_STALE_REF"}`), new(any)) == nil {
  366. t.Fatal("page error ignored")
  367. }
  368. if decode(json.RawMessage(strings.Repeat(" ", 513*1024)), new(any)) == nil {
  369. t.Fatal("oversized result accepted")
  370. }
  371. }
  372. func TestConfigurationAndEngineFailure(t *testing.T) {
  373. if _, e := New(Config{}, nil); e == nil {
  374. t.Fatal("nil driver accepted")
  375. }
  376. for _, cfg := range []Config{{MaxSessions: -1}, {MaxPages: 99}, {MaxResultBytes: 1}, {MaxDownloadBytes: -1}, {Timeout: 6 * time.Minute}} {
  377. if _, e := New(cfg, &fakeDriver{}); e == nil {
  378. t.Fatal("invalid config accepted")
  379. }
  380. }
  381. m, e := New(Config{DataDir: t.TempDir()}, &fakeDriver{open: func(context.Context, api.EngineOptions) (api.EngineSession, error) {
  382. return nil, errors.New("startup failed")
  383. }})
  384. if e != nil {
  385. t.Fatal(e)
  386. }
  387. defer m.Close()
  388. if _, e = m.CreateSession(context.Background(), testOwner); e == nil {
  389. t.Fatal("engine failure hidden")
  390. }
  391. if _, e = m.Capabilities(context.Background()); e != nil {
  392. t.Fatal(e)
  393. }
  394. }
  395. func TestManagedFilesAndSecureExport(t *testing.T) {
  396. m, _, s, p := fixture(t, false)
  397. ctx := context.Background()
  398. file, e := m.Capture(ctx, testOwner, s.ID, p.PageID)
  399. if e != nil {
  400. t.Fatal(e)
  401. }
  402. if file.Size == 0 || file.SHA256 == "" {
  403. t.Fatal("missing file metadata")
  404. }
  405. files, e := m.Files(ctx, testOwner, s.ID)
  406. if e != nil || len(files) != 1 {
  407. t.Fatal(files, e)
  408. }
  409. dest := t.TempDir()
  410. if _, e = m.Export(ctx, testOwner, s.ID, file.ID, dest, "capture.png"); e != nil {
  411. t.Fatal(e)
  412. }
  413. if _, e = m.Export(ctx, testOwner, s.ID, file.ID, dest, "capture.png"); e == nil {
  414. t.Fatal("overwrite allowed")
  415. }
  416. for _, path := range []string{"../escape", "/tmp/escape", "a/../b", "a\\b", "a//b"} {
  417. if _, e = m.Export(ctx, testOwner, s.ID, file.ID, dest, path); e == nil {
  418. t.Fatalf("unsafe path accepted: %s", path)
  419. }
  420. }
  421. outside := t.TempDir()
  422. if os.Symlink(outside, filepath.Join(dest, "link")) == nil {
  423. if _, e = m.Export(ctx, testOwner, s.ID, file.ID, dest, "link/escaped.png"); e == nil {
  424. t.Fatal("symlink escape allowed")
  425. }
  426. }
  427. if _, e = m.Export(ctx, testOwner, s.ID, "unknown", dest, "x"); e == nil {
  428. t.Fatal("unknown file exported")
  429. }
  430. if safeName("../../a\\b\x00.cif") != "b.cif" {
  431. t.Fatal("unsafe suggested name")
  432. }
  433. }
  434. func TestFileLimitsDownloadImportAndCanceledCopy(t *testing.T) {
  435. m, s, info, p := fixture(t, false)
  436. ctx := context.Background()
  437. owned, _ := m.owned(testOwner, info.ID)
  438. if _, e := m.store(owned, "big.bin", "", strings.NewReader("1234"), 3); e == nil {
  439. t.Fatal("file limit ignored")
  440. }
  441. if e := os.WriteFile(filepath.Join(owned.downloadDir, "guid"), []byte("download"), 0600); e != nil {
  442. t.Fatal(e)
  443. }
  444. s.downloads = []api.Download{{ID: "guid", Name: "../../data.cif", Path: filepath.Join(owned.downloadDir, "guid"), State: "completed"}}
  445. files, e := m.Files(ctx, testOwner, info.ID)
  446. if e != nil || len(files) != 1 || files[0].Name != "data.cif" {
  447. t.Fatal(files, e)
  448. }
  449. files, e = m.Files(ctx, testOwner, info.ID)
  450. if e != nil || len(files) != 1 {
  451. t.Fatal("duplicate import", e)
  452. }
  453. s.page.png = []byte("bad")
  454. if _, e = m.Capture(ctx, testOwner, info.ID, p.PageID); e == nil {
  455. t.Fatal("invalid PNG stored")
  456. }
  457. stopped, cancel := context.WithCancel(ctx)
  458. cancel()
  459. if _, e = copyContext(stopped, io.Discard, strings.NewReader("data")); !errors.Is(e, context.Canceled) {
  460. t.Fatal(e)
  461. }
  462. var dst bytes.Buffer
  463. n, e := copyContext(ctx, &dst, strings.NewReader(strings.Repeat("x", 70000)))
  464. if e != nil || n != 70000 {
  465. t.Fatal(n, e)
  466. }
  467. }