Browse Source

Chore: fix lint

loyalsoldier 4 years ago
parent
commit
090a659cab

+ 1 - 2
app/browserforwarder/forwarder.go

@@ -37,7 +37,6 @@ func (f *Forwarder) ServeHTTP(writer http.ResponseWriter, request *http.Request)
 		fallthrough
 		fallthrough
 	case "index.js":
 	case "index.js":
 		BridgeResource(writer, request, requestPath)
 		BridgeResource(writer, request, requestPath)
-		break
 	case "link":
 	case "link":
 		f.forwarder.ServeBridge(writer, request)
 		f.forwarder.ServeBridge(writer, request)
 	}
 	}
@@ -83,7 +82,7 @@ func BridgeResource(rw http.ResponseWriter, r *http.Request, path string) {
 	data, err := securedload.GetAssetSecured("browserforwarder/" + content)
 	data, err := securedload.GetAssetSecured("browserforwarder/" + content)
 	if err != nil {
 	if err != nil {
 		err = newError("cannot load necessary resources").Base(err)
 		err = newError("cannot load necessary resources").Base(err)
-		http.Error(rw, err.Error(), 403)
+		http.Error(rw, err.Error(), http.StatusForbidden)
 		return
 		return
 	}
 	}
 
 

+ 0 - 1
common/platform/securedload/embeddedhash.go

@@ -30,7 +30,6 @@ func (e EmbeddedHashProtectedLoader) VerifyAndLoad(filename string) ([]byte, err
 				return filecontent, nil
 				return filecontent, nil
 			}
 			}
 		}
 		}
-
 	}
 	}
 	return nil, newError("Unrecognized file at ", filename, " can not be loaded for execution")
 	return nil, newError("Unrecognized file at ", filename, " can not be loaded for execution")
 }
 }

+ 3 - 4
common/platform/securedload/file.go

@@ -3,16 +3,15 @@ package securedload
 import "path/filepath"
 import "path/filepath"
 
 
 func GetAssetSecured(name string) ([]byte, error) {
 func GetAssetSecured(name string) ([]byte, error) {
-
 	name = filepath.FromSlash(name)
 	name = filepath.FromSlash(name)
 
 
 	var err error
 	var err error
 	for k, v := range knownProtectedLoader {
 	for k, v := range knownProtectedLoader {
-		if loadedData, errLoad := v.VerifyAndLoad(name); errLoad == nil {
+		loadedData, errLoad := v.VerifyAndLoad(name)
+		if errLoad == nil {
 			return loadedData, nil
 			return loadedData, nil
-		} else {
-			err = newError(k, " is not loading executable file").Base(errLoad)
 		}
 		}
+		err = newError(k, " is not loading executable file").Base(errLoad)
 	}
 	}
 	return nil, err
 	return nil, err
 }
 }

+ 2 - 2
transport/internet/websocket/dialer.go

@@ -124,7 +124,7 @@ func (d dialerWithEarlyData) Dial(earlyData []byte) (*websocket.Conn, error) {
 		return nil, newError("websocket delayed dialer cannot encode early data tail").Base(errc)
 		return nil, newError("websocket delayed dialer cannot encode early data tail").Base(errc)
 	}
 	}
 
 
-	conn, resp, err := d.dialer.Dial(d.uriBase+string(earlyDataBuf.Bytes()), d.config.GetRequestHeader())
+	conn, resp, err := d.dialer.Dial(d.uriBase+earlyDataBuf.String(), d.config.GetRequestHeader())
 	if err != nil {
 	if err != nil {
 		var reason string
 		var reason string
 		if resp != nil {
 		if resp != nil {
@@ -161,7 +161,7 @@ func (d dialerWithEarlyDataRelayed) Dial(earlyData []byte) (io.ReadWriteCloser,
 		return nil, newError("websocket delayed dialer cannot encode early data tail").Base(errc)
 		return nil, newError("websocket delayed dialer cannot encode early data tail").Base(errc)
 	}
 	}
 
 
-	conn, err := d.forwarder.DialWebsocket(d.uriBase+string(earlyDataBuf.Bytes()), d.config.GetRequestHeader())
+	conn, err := d.forwarder.DialWebsocket(d.uriBase+earlyDataBuf.String(), d.config.GetRequestHeader())
 	if err != nil {
 	if err != nil {
 		var reason string
 		var reason string
 		return nil, newError("failed to dial to (", d.uriBase, ") with early data: ", reason).Base(err)
 		return nil, newError("failed to dial to (", d.uriBase, ") with early data: ", reason).Base(err)