Browse Source

Merge pull request #107 from Loyalsoldier/fix-empty-rules-and-dns

Fix: loging empty rules & DNS
RPRX 5 years ago
parent
commit
1ff89cda11
1 changed files with 6 additions and 2 deletions
  1. 6 2
      app/dns/server.go

+ 6 - 2
app/dns/server.go

@@ -379,8 +379,12 @@ func (s *Server) lookupIPInternal(domain string, option IPOption) ([]net.IP, err
 			domainRules = append(domainRules, fmt.Sprintf("%s(DNS idx:%d)", rule, info.clientIdx))
 			matchingDNS = append(matchingDNS, s.clients[info.clientIdx].Name())
 		}
-		newError("domain ", domain, " matching following rules: ", domainRules).AtDebug().WriteToLog()
-		newError("domain ", domain, " uses following DNS first: ", matchingDNS).AtDebug().WriteToLog()
+		if len(domainRules) > 0 {
+			newError("domain ", domain, " matches following rules: ", domainRules).AtDebug().WriteToLog()
+		}
+		if len(matchingDNS) > 0 {
+			newError("domain ", domain, " uses following DNS first: ", matchingDNS).AtDebug().WriteToLog()
+		}
 		for _, idx := range indices {
 			clientIdx := int(s.matcherInfos[idx].clientIdx)
 			matchedClient = s.clients[clientIdx]