Browse Source

Fix unused variables

v2ray 9 years ago
parent
commit
a7f40da07a

+ 3 - 1
common/protocol/raw/client.go

@@ -129,7 +129,9 @@ func (this *ClientSession) DecodeResponseHeader(reader io.Reader) (*protocol.Res
 		}
 		data := buffer.Value[:dataLen]
 		command, err := UnmarshalCommand(cmdId, data)
-		header.Command = command
+		if err == nil {
+			header.Command = command
+		}
 	}
 
 	return header, nil

+ 1 - 1
common/uuid/uuid_test.go

@@ -18,7 +18,7 @@ func TestParseBytes(t *testing.T) {
 	assert.Error(err).IsNil()
 	assert.String(uuid).Equals(str)
 
-	uuid, err = ParseBytes([]byte{1, 3, 2, 4})
+	_, err = ParseBytes([]byte{1, 3, 2, 4})
 	assert.Error(err).Equals(ErrorInvalidID)
 }
 

+ 2 - 0
proxy/internal/config/config_cache_test.go

@@ -24,6 +24,7 @@ func TestRegisterInboundConfig(t *testing.T) {
 	assert.Error(err).IsNil()
 
 	configObj, err = CreateOutboundConfig(protocol, nil)
+	assert.Error(err).IsNotNil()
 	assert.Pointer(configObj).IsNil()
 }
 
@@ -44,5 +45,6 @@ func TestRegisterOutboundConfig(t *testing.T) {
 	assert.Error(err).IsNil()
 
 	configObj, err = CreateInboundConfig(protocol, nil)
+	assert.Error(err).IsNotNil()
 	assert.Pointer(configObj).IsNil()
 }