Pārlūkot izejas kodu

add comment for gRPC TLS silent failure behavior
When gRPC transport have been configured to use TLS, it may silently ignore TLS failure. This may make it harder to diagnose TLS setting issues when gRPC transport is used. This comment is added to help other developers be aware of this caveat.

Shelikhoo 4 gadi atpakaļ
vecāks
revīzija
ebdacfdb86
1 mainītis faili ar 1 papildinājumiem un 0 dzēšanām
  1. 1 0
      transport/internet/grpc/hub.go

+ 1 - 0
transport/internet/grpc/hub.go

@@ -75,6 +75,7 @@ func Listen(ctx context.Context, address net.Address, port net.Port, settings *i
 	if config == nil {
 		s = grpc.NewServer()
 	} else {
+		// gRPC server may silently ignore TLS errors
 		s = grpc.NewServer(grpc.Creds(credentials.NewTLS(config.GetTLSConfig(tls.WithNextProto("h2")))))
 	}
 	listener.s = s